Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ethers-v6 target to support Result methods #818

Closed
wants to merge 1 commit into from
Closed

Update ethers-v6 target to support Result methods #818

wants to merge 1 commit into from

Conversation

shirotech
Copy link

fixes #817

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2023

⚠️ No Changeset found

Latest commit: 2f10461

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@krzkaczor
Copy link
Member

Thanks! Merged as : #866

@krzkaczor krzkaczor closed this Aug 20, 2023
@krzkaczor krzkaczor reopened this Aug 21, 2023
@krzkaczor
Copy link
Member

Sorry, no this is not merged yet.

@shirotech
Copy link
Author

@krzkaczor please let me know anything you need on this before it can be merged? Thank you.

@krzkaczor
Copy link
Member

@shirotech can you rebase with current master and run test:fix and fix all the errors. Please follow contributing guide when in doubt.

@handanyolak
Copy link

Are there any updates here?

@shirotech shirotech closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethers-v6: Please consider implementing Result methods like toArray() and toObject()
3 participants