Cops car is not rendered on damage gallery

[rafalp]

Finish race with cop car and go to damage gallery, it won't be displayed:

[zear]

@madebr @dethrace-labs
This happens, because BrModelUpdate nukes vertices for the Squad Car's model:

dethrace/src/BRSRC13/CORE/V1DB/prepmesh.c

Lines 683 to 694 in 889e7ba

	if (!(model->flags & BR_MODF_UPDATEABLE)) {
	if (model->faces) {
	BrResFree(model->faces);
	}
	if (model->vertices) {
	BrResFree(model->vertices);
	}
	model->vertices = NULL;
	model->nfaces = 0;
	model->nvertices = 0;
	model->faces = NULL;
	}

Squad Car is a bit special, because it is the only car that doesn't have damage model [1]. As such, the code deals with it explicitly:

dethrace/src/DETHRACE/common/loading.c

Lines 1690 to 1694 in 889e7ba

	if (pOwner == eDriver_net_human || gAusterity_mode) {
	if ((pModel->flags & BR_MODF_UPDATEABLE) != 0) {
	pModel->flags &= ~(BR_MODF_KEEP_ORIGINAL | BR_MODF_UPDATEABLE);
	BrModelUpdate(pModel, BR_MODU_ALL);
	}

Here pOwner == 3 does not mean tDriver type value, but rather the opponent number of the Squad Car.

Same wrong assumptions are made here:

dethrace/src/DETHRACE/common/loading.c

Lines 2230 to 2231 in 889e7ba

	// Jeff: Bug? pOwner will never be 3. Probably this was supposed to be "pDriver == eDriver_net_human"?
	if (pOwner == 3 || gAusterity_mode) {

and here:

dethrace/src/DETHRACE/common/loading.c

Line 2238 in 889e7ba

if (pCar_spec->driver < eDriver_net_human || gAusterity_mode) {

I don't have the OG assembly to confirm where this issue stems from, but it sounds like the BR_MODF_KEEP_ORIGINAL | BR_MODF_UPDATEABLE flags should not have been removed for this model.

When said flags are forcibly set, Squad Car ends up being rendered correctly:

[1] https://carmageddon.fandom.com/wiki/The_Cops

[madebr]

This is also the behavior in OG (tested with CARM95.EXE).
A fix can be added using preprocessor define DETHRACE_FIX_BUGS.