Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement edit functions + functions around camera + ... #146

Merged
merged 13 commits into from
Sep 28, 2022
Merged

Implement edit functions + functions around camera + ... #146

merged 13 commits into from
Sep 28, 2022

Conversation

madebr
Copy link
Collaborator

@madebr madebr commented Sep 7, 2022

  • Implement all flicplay functions (even those unused by the .FLI files in Carmageddon's game data)
  • Implement edit functions for moving car
  • Implement edit functions for adding actors/special volumes
  • Implement depth related functions
  • Fixes bug in car.c (introduced by me)

madebr
madebr commented Sep 7, 2022
View reviewed changes
src/DETHRACE/common/depth.c
Comment on lines +152 to +155
a = cosf(BrAngleToRadian(pPerfect));
b = sinf(BrAngleToRadian(pView));
c = cosf(BrAngleToRadian(pView));
return b * a * a / (BrAngleToRadian(pSky) * (1.f + c));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a close look at this function as I'm not sure of it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dethrace-labs
Copy link
Owner

I tried a couple of the accessory edit functions, I can't get them to work. Either locking on to the nearest or spawning a new accessory doesn't seem to work as expected (maybe they are being spawned in the wrong place?)

@madebr
Copy link
Collaborator Author

madebr commented Sep 15, 2022

I tried a couple of the accessory edit functions, I can't get them to work. Either locking on to the nearest or spawning a new accessory doesn't seem to work as expected (maybe they are being spawned in the wrong place?)

Indeed, I missed to set the translation vector when the SHIFT` button was not pressed.
(The shift button is for axis aligning the actor when spawning on e.g. a hill, instead of aligning the object on the surface)

@dethrace-labs dethrace-labs merged commit db3d6ac into dethrace-labs:main Sep 28, 2022
@madebr madebr deleted the edit-functions branch September 28, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dethrace-labs dethrace-labs dethrace-labs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madebr @dethrace-labs