Implement DoEndSummary2 (aka Damage Gallery)

[madebr]

This pr implements the post-race "Damage Gallery".

[madebr]

The line:

sel_actor->render_style = BR_RSTYLE_NONE;

is the only difference with Carmageddon, because rendering bounding boxes is not implemented (yet) by the opengl renderern.

[dethrace-labs]

I'm getting some compiler warnings on this new code -

few of these ones:

src/DETHRACE/common/racesumm.c:1005:34: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
                    difference = abs(gWreck_array[i].pos_x - gWreck_array[gWreck_selected].pos_x);
                                 ^

src/DETHRACE/common/racesumm.c:1046:9: warning: variable 'old_mouse_x' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (gWreck_zoomed_in < 0) {

for things like old_mouse_x, in the past I've just initialized them to 0 in their declaration to get a clean build

[madebr]

I'm getting some compiler warnings on this new code -

We really need to reduce the number of warnings to 0.
Because right now potential critical warnings are drown in silly warnings.
Right now, CI is just there to signal fail/no fail.
For rec2, I make it a point to have 0 warnings so every warning gets my full attention.

src/DETHRACE/common/racesumm.c:1005:34: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
                    difference = abs(gWreck_array[i].pos_x - gWreck_array[gWreck_selected].pos_x);
                                 ^

This one is intentional, to silence the warning an explicit (int) needs to be added.

src/DETHRACE/common/racesumm.c:1046:9: warning: variable 'old_mouse_x' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (gWreck_zoomed_in < 0) {

for things like old_mouse_x, in the past I've just initialized them to 0 in their declaration to get a clean build

This indeed needs an explicit initialization.

I don't think there is a general way of tagging variables to say they are written by a function. Microsoft has SAL annotations but idk about other compilers.

[dethrace-labs]

We really need to reduce the number of warnings to 0.

Agree. We used to have this, but over time the number has crept up. Its not bad on gcc/clang, but I think on windows (where I don't spend much time) is worse.

Need to be more intentional with the warnings we enable probably, things like "variable initialized but not used" shouldn't be flagged - we are replicating existing logic rather than writing everything as cleanly as possible.