No more gcc/clang warnings #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn-type warnings
Fixes these types of warnings:
cast between incompatible function types from ‘br_uint_32 (*)(br_actor *, void *)’ {aka ‘unsigned int (*)(struct br_actor *, void *)’} to ‘intptr_t (*)(br_actor *, void *)’ {aka ‘long int (*)(struct br_actor *, void *)’} [-Wcast-function-type]
|
I also fixed a few |
src/DETHRACE/common/opponent.c
Outdated
| BrVector3Cross(&displacement, &positive_y_vector, &direction_v); | ||
| BrVector3Normalise(&displacement, &displacement); | ||
| BrVector3Scale(&displacement, &displacement, (pMassage_count / 4) * 0.1f); | ||
| } else { | ||
| BrVector3Normalise(&displacement, &displacement); | ||
| BrVector3Scale(&displacement, &displacement, (pMassage_count / 4) * 0.5f); | ||
| BrVector3Normalise(&direction_v, &direction_v); |
There was a problem hiding this comment.
I think you're right - the original code here is not quite correct. After looking at it again, I think it should be this though (slightly different from what you propose:
BrVector3Normalise(&displacement, &direction_v);
BrVector3Scale(&displacement, &displacement, (pMassage_count / 4) * 0.5f);
madebr
commented
Sep 23, 2022
dethrace-labs
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes all gcc/clang warnings.
-Werrorfor Apple/clang is not (yet) enabled, as I would like to fix MSVC warnings in a future pr first.