Workflow Updates

[dethrace-labs]

• simplifies workflow yaml
• stops double-running workflow on pull request and push. Workflow can be forced to run without opening a PR by naming your branch in the format ci-*
• generates downloadable artifacts on each push to main
• releases named in the form of Dethrace 0.4.0 rather than Dethrace v0.4.0 to match the more common convention

[madebr]

I think you need to add -DCMAKE_OSX_ARCHITECTURES=x86_64 (or amd64 idk) to be sure this does not build an armv8 executable.
Speaking of armv8, perhaps add armv8 to the build matrix for macos?

See CMAKE_OSX_ARCHITECTURES.
I think you can build a "fat" executable by doing -DCMAKE_OSX_ARCHITECTURES="x86_64;armv8", but don't quote me on that :)

[dethrace-labs]

thanks. github actions don't yet support arm osx builds (actions/runner-images#2187), so I've set it just to x86_x64 for now

[madebr]

We don't need M1 hardware. We just want to cross build to armv8.

[madebr]

Actually, we do when we run the tests. So you're right.
Unless we disable them for that platform alone.

[madebr]

This is just cosmetic, but can you please add a final new line to all files to avoid GitHub adding this marker.

[dethrace-labs]

thanks. I moved to a new laptop and forgot to turn on the auto-insert newlines setting 👍

[madebr]

On my dev machine, I added a .editorconfig in the root folder of my user home dir containing:

root = true

[*]
end_of_line = lf
insert_final_newline = true

[Makefile]
indent_style = tab
indent_size = 4

[*.py]
indent_style = space
tab_width = 4

And all my ide's are configured to use editorconfig files.

When some project has another default, I add an .editorconfig file in that projects root directory.
To avoid git picking up that file, I added .editorconfig to .gitignore in my user home directory.

[madebr]

On Linux and Macos, we implicitly assume people have SDL2 somehow installed.
Should we add libSDL2.(dylib|so) to the archive?
In that case, we might need to fix rpaths.

Food for thoughts, and for a later pr.

[dethrace-labs]

yep - I ran into this problem on a different laptop where libsdl2 was not in the expected place. Definitely an issue to fix - I think as part of generating a fat .app package for macos

[madebr]

Can we collapse the windows job into this job by adding the build script into the matrix?
e.g.:

matrix:
    include:
      - os: 'ubuntu-latest'
        script: '.github/scripts/build-linux.sh'
      - os: 'macos-latest'
        script: '.github/scripts/build-macos.sh'
      - os: 'windows-latest'
        script: '.github\\scripts\\build-msvc.ps1'

[dethrace-labs]

I considered that, but for windows we currently build with an additional platform matrix, so I wasn't sure how we should deal with that. Probably the easiest way would be to drop support for 32 bit windows builds, but its quite nice being able to build for the original architecture

[madebr]

Let's leave 32-bit builds enabled, if not for checking our pointer arithmetic is correct.

You mean the ilammy/msvc-dev-cmd@v1.4.1 step? That can be made conditional on the os using

      - uses: ilammy/msvc-dev-cmd@v1.4.1
        if: contains(matrix.os, 'windows')
        with:
          arch: ${{ matrix.platform }}

[madebr]

And the platforms can then only be added to the Windows items.

    include:
      - os: 'ubuntu-latest'
        script: '.github/scripts/build-linux.sh'
      - os: 'macos-latest'
        script: '.github/scripts/build-macos.sh'
      - os: 'windows-latest'
        script: '.github\\scripts\\build-msvc.ps1'
        platform: 'x86'
      - os: 'windows-latest'
        script: '.github\\scripts\\build-msvc.ps1'
        platform: 'amd64'

[dethrace-labs]

no, I mean for windows we build x86 and x64. Ah, just saw your other comment, yep that should owrk

[madebr]

Something what bothers me with the current Linux release is that the tarball contains a build folder.
How about we create a dethrace-${BUILD_TAG}-darwin-amd64 directory, and tar that directory?

Suggested change

	tar -czvf dethrace-${BUILD_TAG}-darwin-amd64.tar.gz build/dethrace
	echo "::set-output name=filename::dethrace-${BUILD_TAG}-darwin-amd64.tar.gz"
	releasename="dethrace-${BUILD_TAG}-darwin-amd64"
	rm -rf "$releasename"
	mkdir "$releasename"
	cp build/dethrace "$releasename/dethrace"
	tar -czvf "$releasename.tar.gz" "$releasename"
	echo "::set-output name=filename::"$releasename.tar.gz"

[madebr]

The same applies to the Macos release binary.
The Windows zip contains no directories.