Fix oil spill rendering #240
Conversation
|
I just checked and the ordering is 1:1 as used in I think the issue is our renderer does not respect the |
|
Btw, you're always welcome to join the Carmageddon Discord server to discuss various problems. |
|
I also just noticed the non-rendering of an oil spill, even though it caused the tyres to slip and an oil track to form. |
|
Updated the patch with gl renderer support of The oil spills now also render at the same time other back-faced geometry is properly culled (#187):
Thanks, but I'm not using walled garden ecosystems. Unless you guys have an IRC channel :) |
| @@ -549,6 +550,10 @@ void GLRenderer_Model(br_actor* actor, br_model* model, br_matrix34 model_matrix | |||
| glUniform1i(uniforms_3d.light_value, -1); | |||
| } | |||
|
|
|||
| twosided = actor->material && actor->material->flags & BR_MATF_TWO_SIDED; | |||
| if (twosided) | |||
| glDisable(GL_CULL_FACE); | |||
There was a problem hiding this comment.
I would put this code in SetActiveMaterial.
And by framing it like this, we don’t have to have a separate piece of reset code.
if (double sided)
glDisable(culling)
else
glEnable(culling
There was a problem hiding this comment.
I thought about this initially, but the problem with doing so is that you can leave the culling disabled if the last model had BR_MATF_TWO_SIDED. So if anything else is rendered in the frame after the models, it might cause problems.
There was a problem hiding this comment.
I think that’s ok - either the next thing to be rendered is:
- another model with its own materials which will setup the rendering
config with its own settings - or that model was the last one, and we move on
to rendering the framebuffer. In this case it doesn’t care about
culling, but generally should be setting up the rendering config regardless of
what the current config is
There was a problem hiding this comment.
Updated the patch to reflect the discussion.
| @@ -41,6 +41,7 @@ void InitOilSpills() { | |||
| the_material->flags |= BR_MATF_LIGHT; | |||
| the_material->flags |= BR_MATF_PERSPECTIVE; | |||
| the_material->flags |= BR_MATF_SMOOTH; | |||
| the_material->flags |= BR_MATF_TWO_SIDED; | |||
There was a problem hiding this comment.
| the_material->flags |= BR_MATF_TWO_SIDED; | |
| // TODO: added by dethrace, investigate why oil spills in OG do not need this flag set to render correctly | |
| the_material->flags |= BR_MATF_TWO_SIDED; |
| if (material->flags & BR_MATF_TWO_SIDED) | ||
| glDisable(GL_CULL_FACE); | ||
| else | ||
| glEnable(GL_CULL_FACE); | ||
|
|
There was a problem hiding this comment.
| if (material->flags & BR_MATF_TWO_SIDED) | |
| glDisable(GL_CULL_FACE); | |
| else | |
| glEnable(GL_CULL_FACE); | |
| if (material->flags & BR_MATF_TWO_SIDED || material->flags & BR_MATF_ALWAYS_VISIBLE) { | |
| glDisable(GL_CULL_FACE); | |
| } else { | |
| glEnable(GL_CULL_FACE); | |
| } |
There was a problem hiding this comment.
there is another flag BR_MATF_ALWAYS_VISIBLE that we should probably treat the same way
…SIBLE Prevent the gl renderer from culling back-faced textures if the material is two-sided or always visible. Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
Due to the wrong order of vertices in the model, oil spill object is subject to back face culling, preventing it from being rendered. Set the oil spill material as two-sided, allowing it to be displayed. Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
Due to the wrong order of vertices in the model, oil spill object is subject to back face culling, preventing it from being rendered. Make the oil spill front faced w/ regards to the floor.
Note: Setting
BR_MATF_TWO_SIDEDfor the material flags does not solve this problem - the oil spill is still invisible. Has the original order of vertices been taken from OG disassembly?