Use BRender macro's + floats + move around code blocks #250
Conversation
Co-authored-by: Dethrace Engineering Department <78985374+dethrace-labs@users.noreply.github.com>
| v1 = fp->vertices[0]; | ||
| a.v[0] = prepared->groups[group].vertices[v1].p.v[0] - bnds->box_centre.v[0]; |
There was a problem hiding this comment.
it breaks my brain looking at this bit, I'm going to skip past and assume its all good! :). Nice one!
There was a problem hiding this comment.
I'm fixing the conflicts atm.
It's okay if you need more time to check everything.
There was a problem hiding this comment.
all good, happy to merge as-is. I think these days we have enough history of functional behavior in PRs that it is relatively easy to step back in time if we see new unexpected behavior and tie it to a particular PR 👍
Co-authored-by: Dethrace Engineering Department <78985374+dethrace-labs@users.noreply.github.com>
|
Are you ok to merge this now? |
Yes, but I would like to give it a last review tomorrow |
| @@ -48,7 +48,7 @@ void (*ControlCar[6])(tCar_spec*, br_scalar) = { | |||
| &ControlCar3, | |||
| &ControlCar4, | |||
| &ControlCar5, | |||
| NULL | |||
| NULL, | |||
There was a problem hiding this comment.
What is our convention about last comma in arrays?
Ancient compilers (gcc 3.x-era) do not support this.
My 2c is to don't care at the moment and do something about this when it's needed.
There was a problem hiding this comment.
Agree - I don't really mind either way. I don't generally add it myself.
The changes in this pr can be categorized in the following categories:
fabsf)BoundsOverlapTest__finteray)Functionally difference should be nil.