upgrade to selenium-java 2.47.1 and Java 7 #462

asolntsev · 2015-08-10T05:42:00Z

Starting from version 2.47, selenium-java requires Java 7 or higher.
I believe ghostdriver could also require Java 7.

detro · 2015-08-11T12:22:13Z

binding/java/build.gradle

@@ -105,6 +105,10 @@ task sourceJar(type: Jar, dependsOn: classes) {
    }
 }

+javadoc {
+    failOnError = false


Otherwise "./gradle" command always fails for me. It reports that many
javadocs are invalid.
On Aug 11, 2015 3:22 PM, "Ivan De Marino" notifications@github.com wrote:

In binding/java/build.gradle
#462 (comment):

@@ -105,6 +105,10 @@ task sourceJar(type: Jar, dependsOn: classes) {
}
}

+javadoc {

failOnError = false

why this?

—
Reply to this email directly or view it on GitHub
https://github.com/detro/ghostdriver/pull/462/files#r36738269.

detro · 2015-08-11T12:23:31Z

I know that running tests as part of this build is long overdue.
But did you?
Do tests still pass if you update to include latest Selenium Java?

detro · 2015-08-12T07:48:01Z

@asolntsev Still need your input on the general question about what would break if we update to the latest JAR of Selenium

asolntsev · 2015-08-12T12:26:08Z

Hi Ivan!
No, I cannot run tests. But I also could not run tests before my change.

Do I correctly understand that running tests is just broken, and
build.gradle needs to be fixed? Do you need my help with this?

Andrei Solntsev

2015-08-11 15:23 GMT+03:00 Ivan De Marino notifications@github.com:

I know that running tests as part of this build is long overdue.
But did you?
Do tests still pass if you update to include latest Selenium Java?

—
Reply to this email directly or view it on GitHub
#462 (comment).

detro · 2015-08-17T11:18:33Z

Mmm,

well, Java tests used to work.
So something of what I merged must have broken them.

Changing Selenium version will definitely broke stuff further: changing selenium library usually breaks even compilation.

asolntsev · 2015-08-17T11:25:59Z

I mean, I cannot even run gradle script, because

Gradle requires variables like "ossrhUsername" and "ossrhPassword". I
don't have these variables, and they should not be required to compile/run
tests locally.
Path to phantomJS is hardcoded

I suggest fixing these issues so that everyone can easily run tests on his
machine without need to modify scripts.

Andrei Solntsev

2015-08-17 14:18 GMT+03:00 Ivan De Marino notifications@github.com:

Mmm,

well, Java tests used to work.
So something of what I merged must have broken them.

Changing Selenium version will definitely broke stuff further: changing
selenium library usually breaks even compilation.

—
Reply to this email directly or view it on GitHub
#462 (comment).

detro · 2015-08-19T10:31:25Z

Go for it!

Yes, given I was the only maintainer and there was LOTS to do, I wrote a very shitty build setup.

So if you can solve those issues, and push the version of selenium to the latest, go for it.

asolntsev · 2015-08-19T12:02:57Z

Ok, I will do it with great pleasure!

P.S. Why are java tests separate from java code? I didn't notice them until
you mentioned that there are tests.
What you think if we move java tests from
https://github.com/detro/ghostdriver/tree/master/test/java into the
https://github.com/detro/ghostdriver/tree/master/binding/java folder?

Andrei Solntsev

2015-08-19 13:31 GMT+03:00 Ivan De Marino notifications@github.com:

Go for it!

Yes, given I was the only maintainer and there was LOTS to do, I wrote a
very shitty build setup.

So if you can solve those issues, and push the version of selenium to the
latest, go for it.

—
Reply to this email directly or view it on GitHub
#462 (comment).

detro · 2015-08-19T13:39:25Z

So, it works like this:

the one in binding are source code of the PhantomJSDriver classes: the Java binding for GhostDriver
the one in test are tests (that use the binding) but are focused on testing the protocol implementation and all the functionalities

Maybe another bad idea of mine.

asolntsev · 2015-09-01T20:12:52Z

Ivan,
sorry, I cannot develop pull requests for ghostdriver right now because I
am preparing for the SeleniumConf http://year-2015.seleniumconf.org/. By
the way, aren't you going there?

I will get back to ghostdriver when I return from SeleniumConf after 2
weeks.

Andrei Solntsev

2015-08-19 16:39 GMT+03:00 Ivan De Marino notifications@github.com:

So, it works like this:

the one in binding are source code of the PhantomJSDriver classes:
the Java binding for GhostDriver

the one in test are tests (that use the binding) but are focused on
testing the protocol implementation and all the functionalities

Maybe another bad idea of mine.

—
Reply to this email directly or view it on GitHub
#462 (comment).

detro · 2015-09-04T13:57:02Z

@asolntsev I know. I'll be there at the New Relic stand, and I was planning to watch your presentation. Best of luck with that!

asolntsev · 2015-09-05T13:22:03Z

Wow!
It's greate news! Meet you there.

Andrei Solntsev

2015-09-04 16:57 GMT+03:00 Ivan De Marino notifications@github.com:

@asolntsev https://github.com/asolntsev I know. I'll be there at the
New Relic stand, and I was planning to watch your presentation. Best of
luck with that!

—
Reply to this email directly or view it on GitHub
#462 (comment).

asolntsev · 2016-03-02T22:51:49Z

Hi Ivan!
People are asking for phantojsdriver upgrades.

It seems that it's the most simple option to keep updating my fork
https://github.com/asolntsev/ghostdriver now if you don't mind...

Andrei Solntsev

2015-09-05 16:21 GMT+03:00 Andrei Solntsev andrei.solntsev@gmail.com:

Wow!
It's greate news! Meet you there.

Andrei Solntsev

2015-09-04 16:57 GMT+03:00 Ivan De Marino notifications@github.com:

@asolntsev https://github.com/asolntsev I know. I'll be there at the
New Relic stand, and I was planning to watch your presentation. Best of
luck with that!

—
Reply to this email directly or view it on GitHub
#462 (comment).

solvingj · 2016-03-02T23:23:36Z

+1

Gerald R. Wiltse
jerrywiltse@gmail.com

On Wed, Mar 2, 2016 at 5:51 PM, Andrei Solntsev notifications@github.com
wrote:

Hi Ivan!
People are asking for phantojsdriver upgrades.

It seems that it's the most simple option to keep updating my fork
https://github.com/asolntsev/ghostdriver now if you don't mind...

Andrei Solntsev

2015-09-05 16:21 GMT+03:00 Andrei Solntsev andrei.solntsev@gmail.com:

Wow!
It's greate news! Meet you there.

Andrei Solntsev

2015-09-04 16:57 GMT+03:00 Ivan De Marino notifications@github.com:

@asolntsev https://github.com/asolntsev I know. I'll be there at the
New Relic stand, and I was planning to watch your presentation. Best of
luck with that!

—
Reply to this email directly or view it on GitHub
#462 (comment).

—
Reply to this email directly or view it on GitHub
#462 (comment).

asolntsev · 2016-04-21T21:03:58Z

@detro @jerrywiltse For your information, I have created a fork: https://github.com/codeborne/ghostdriver

I updated it a little bit:

upgraded to Java 7 and Selenium 2.53.0.
upgraded to gradle 2.12
fixed few javadocs
ignored few failing tests

I have also set up a build server: https://ci.selenide.org/view/libs/job/phantomjsdriver/

And now it have built a phantomjsdriver 1.3.0-SNAPSHOT: https://oss.sonatype.org/content/repositories/snapshots/com/codeborne/phantomjsdriver/1.3.0-SNAPSHOT/

solvingj · 2016-04-22T18:24:29Z

Amazing work Andrei, thank you so much!

Gerald R. Wiltse
jerrywiltse@gmail.com

On Thu, Apr 21, 2016 at 5:04 PM, Andrei Solntsev notifications@github.com
wrote:

@detro https://github.com/detro @jerrywiltse
https://github.com/jerrywiltse For your information, I have created a
fork: https://github.com/codeborne/ghostdriver

I updated it a little bit:

upgraded to Java 7 and Selenium 2.53.0.

upgraded to gradle 2.12

fixed few javadocs

ignored few failing tests

I have also set up a build server:
https://ci.selenide.org/view/libs/job/phantomjsdriver/

And now it have built a phantomjsdriver 1.3.0-SNAPSHOT:
https://oss.sonatype.org/content/repositories/snapshots/com/codeborne/phantomjsdriver/1.3.0-SNAPSHOT/

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#462 (comment)

upgrade to selenium-java 2.47.1 and Java 7

8cdcbe9

detro reviewed Aug 11, 2015
View reviewed changes

detro closed this Mar 21, 2017

asolntsev deleted the upgrade-to-selenium-247-and-java7 branch May 10, 2017 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade to selenium-java 2.47.1 and Java 7 #462

upgrade to selenium-java 2.47.1 and Java 7 #462

asolntsev commented Aug 10, 2015

detro Aug 11, 2015

asolntsev Aug 11, 2015

detro Aug 12, 2015

detro commented Aug 11, 2015

detro commented Aug 12, 2015

asolntsev commented Aug 12, 2015

detro commented Aug 17, 2015

asolntsev commented Aug 17, 2015

detro commented Aug 19, 2015

asolntsev commented Aug 19, 2015

detro commented Aug 19, 2015

asolntsev commented Sep 1, 2015

detro commented Sep 4, 2015

asolntsev commented Sep 5, 2015

asolntsev commented Mar 2, 2016

solvingj commented Mar 2, 2016

asolntsev commented Apr 21, 2016

solvingj commented Apr 22, 2016

upgrade to selenium-java 2.47.1 and Java 7 #462

upgrade to selenium-java 2.47.1 and Java 7 #462

Conversation

asolntsev commented Aug 10, 2015

detro Aug 11, 2015

Choose a reason for hiding this comment

asolntsev Aug 11, 2015

Choose a reason for hiding this comment

detro Aug 12, 2015

Choose a reason for hiding this comment

detro commented Aug 11, 2015

detro commented Aug 12, 2015

asolntsev commented Aug 12, 2015

detro commented Aug 17, 2015

asolntsev commented Aug 17, 2015

detro commented Aug 19, 2015

asolntsev commented Aug 19, 2015

detro commented Aug 19, 2015

asolntsev commented Sep 1, 2015

detro commented Sep 4, 2015

asolntsev commented Sep 5, 2015

asolntsev commented Mar 2, 2016

solvingj commented Mar 2, 2016

asolntsev commented Apr 21, 2016

solvingj commented Apr 22, 2016