Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jitpack.io docs #519

Merged
merged 1 commit into from
Apr 6, 2017
Merged

update jitpack.io docs #519

merged 1 commit into from
Apr 6, 2017

Conversation

jesg
Copy link
Collaborator

@jesg jesg commented Mar 28, 2017

fixes #518

@jesg jesg requested a review from detro March 28, 2017 11:47
Copy link
Owner

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I have a bit of time to move the project under "ghostdriver" organization, we will take care of changing this again.

For now, good stuff.

PS We should probably split this into 2 or 3 repositories, one with "ghostdriver-core", one with "npm ghostdriver" and one with "java phantomjsdriver bindings".

What do you think?

@jesg
Copy link
Collaborator Author

jesg commented Apr 6, 2017

What do you think?

the "ghostdriver-core" and "java phantomjs bindings" both sound resonable. it would help reduce the confusion between the java client driver and the core ghostdriver code. having a separate project for the npm package would be a bit ackward. we would probably have to copy some of the source files or have a build process that copies the source files from "ghostdriver-core" and publishes to npm.

@jesg jesg merged commit 673c850 into detro:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants