Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update java client selenium dependency #535

Merged
merged 2 commits into from
Jun 6, 2017

Conversation

jesg
Copy link
Collaborator

@jesg jesg commented May 11, 2017

this fix works around a deprecated api in the selenium client.

this change upgrades the selenium dependency from 3.0.0 to 3.1.0. hence i bumped the ghostdriver version from 2.0.0 to 2.1.0.

fixes #528

lmtierney and others added 2 commits April 27, 2017 07:05
* replace deprecated Throwables.propagateIfPossible with Throwables.throwIfUnchecked
* bump version to 2.1.0
* remove SuppressWarnings annotation

fixes #528
@jesg jesg added the bug label May 11, 2017
@jesg jesg requested a review from detro May 11, 2017 13:32
Copy link

@haroon-sheikh haroon-sheikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@detro detro merged commit 72cf75f into detro:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants