Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTParty Proxy Options - Fixes #3 #6

Merged
merged 2 commits into from
Dec 3, 2014
Merged

Support for HTTParty Proxy Options - Fixes #3 #6

merged 2 commits into from
Dec 3, 2014

Conversation

chrisdambrosio
Copy link
Contributor

  • Extract HTTParty from LastPass::Fetcher to LastPass::HTTP
  • HTTP Proxy can be set with LastPass::HTTP.http_proxy:
LastPass::HTTP.http_proxy(address, port)

or

LastPass::HTTP.http_proxy(address, port, username, password)

- Extract HTTParty from LastPass::Fetcher to LastPass::HTTP
- HTTP Proxy can be set with LastPass::HTTP.http_proxy
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.19%) when pulling c5e5386 on chrisdambrosio:proxy_support into a2a3e5b on detunized:master.

@detunized
Copy link
Owner

Chris, thanks for the contribution! I'm gonna merge this. But I would like to add a standard comment header for the new files you've created first. For this project I use this:

# Copyright (C) 2013 Dmitry Yakimenko (detunized@gmail.com).
# Licensed under the terms of the MIT license. See LICENCE for details.

There's a number of ways this can be approached:

  1. Use the same header
  2. Replace my name/email with yours
  3. Change it to something different like Dmitry Yakimenko and coauthors and I'll later replace it everywhere else as well to keep it uniform
  4. Some other option

What do you think?

@chrisdambrosio
Copy link
Contributor Author

No problem, I added the headers =)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.19%) when pulling cdbdb4e on chrisdambrosio:proxy_support into a2a3e5b on detunized:master.

@detunized
Copy link
Owner

Great work, thanks!

detunized added a commit that referenced this pull request Dec 3, 2014
Support for HTTParty Proxy Options - Fixes #3
@detunized detunized merged commit 9423f69 into detunized:master Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants