-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting this to build on Ubuntu 16.04 #28
Getting this to build on Ubuntu 16.04 #28
Conversation
@@ -7,6 +7,6 @@ | |||
|
|||
package engine | |||
|
|||
// #cgo CFLAGS: -I/usr/include/php/20151012 -Iinclude/php7 -Isrc/php7 | |||
// #cgo CFLAGS: -I/usr/include/php/20151012 -I/usr/include/php/20151012/main -I/usr/include/php/20151012/Zend -I/usr/include/php/20151012/TSRM -Iinclude/php7 -Isrc/php7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you break these in two lines, as in php5.go? Otherwise looks great.
@randlem Perfect, thanks for this. Makes complete and total sense, if you can fix the review comments I'll push this ASAP. |
Hmm, I've got a slight issue actually. So building this is fine, but then attempting to invoke it causes essentially the same issue. Here's what I'm looking at (again).
Yeah success! But then....
Go building this gives me....
|
Savestates Approved-by: Matthew Tyas <matthew.tyas@antstream.com>
This commit fixes the issue that @promorphus was having related to issue #26. Works on Ubuntu 16.04 with PHP7 installed from apt.