Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Dialog #1736

Merged
merged 9 commits into from
May 1, 2024
Merged

Share Dialog #1736

merged 9 commits into from
May 1, 2024

Conversation

l1keafox
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc5a023

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@l1keafox l1keafox changed the title icons and formatting Share Dialog Mar 26, 2024
@l1keafox l1keafox marked this pull request as ready for review April 4, 2024 20:52
@l1keafox l1keafox requested review from Enjoy2Live and a team as code owners April 4, 2024 20:52
Enjoy2Live
Enjoy2Live requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@Enjoy2Live Enjoy2Live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, I like this next-share lib for automating the extraction for crucial meta tags from the html document to the shared content.

Please go over my requested changes and let me know if you have any question here, thanks a ton!

packages/UI/src/components/ShareDialog/ShareDialog.tsx Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/ShareDialog.tsx Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/ShareDialog.tsx Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/ShareDialog.tsx Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/ShareDialog.tsx Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/ShareDialog.tsx Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/ShareDialog.mdx Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/index.ts Outdated Show resolved Hide resolved
packages/UI/src/components/ShareDialog/ShareDialog.tsx Outdated Show resolved Hide resolved
@l1keafox l1keafox requested a review from pyxld-kris as a code owner April 18, 2024 16:04
@l1keafox l1keafox requested a review from Enjoy2Live April 18, 2024 16:05
@l1keafox l1keafox requested a review from Enjoy2Live April 24, 2024 00:56
@Enjoy2Live Enjoy2Live changed the base branch from master to development/components May 1, 2024 22:59
@Enjoy2Live Enjoy2Live merged commit 66014d0 into development/components May 1, 2024
5 of 7 checks passed
@dev-launchers-flux
Copy link
Collaborator

🎉 This PR is included in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@chadcrotchett chadcrotchett deleted the ShareDialog branch November 14, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyxld-kris pyxld-kris Awaiting requested review from pyxld-kris pyxld-kris is a code owner

@Enjoy2Live Enjoy2Live Awaiting requested review from Enjoy2Live Enjoy2Live is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l1keafox @dev-launchers-flux @Enjoy2Live