-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevEx] Improve Code Coverage #187
Comments
To support the Dev Recruit team, we should test the APIs for the Applicant and Opportunity collections. The typical flow is a team lead will create an opportunity for a project. Then people will apply for the opportunity. When the role is filled, the opportunity will be unpublished, but not deleted so it can be reused in the future. To test this, we first need to make sure there is a project because an opportunity references a project. Then we need to test create, get, list and update opportunity APIs. Finally, we need to test create and get applicants. |
As part of code coverage, we verify if each line of code is executed at least once. I tested two APIs in total which are listed as below.
|
@chungthuang @becevka are there any specific reasons we want to remove postman tests? Also, is the goal here to have 70% coverage, or 80% coverage? Are these purely internal standards, or are they tied to any regulatory/control systems? |
We are using Playwright because it emphasizes end to end testing. The numbers here are arbitrary, but it would help to align on an internal metric or goal for code coverage. |
We want to improve code coverage in the following files. @nikita-pardeshi-github will post test cases here for review as a next step.
|
Summary
We need to improve overall code coverage and stability
Describe the solution you'd like
We have integrated Playwright in our code, and removed existing Postman based-tests, now we need to improve coverage to achieve at least 80% of line rate.
Acceptance criteria
Given the current code coverage is 42%
When more tests are added
Then the code coverage should reach at least 70% or more
The text was updated successfully, but these errors were encountered: