Added manage_system_users option and formatted properties #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hp197 Thanks for this PR, looks good to me ... could you also please add an entry in README.md? |
|
Sure, will do
…On Sat, Feb 6, 2021, 11:14 Michael Geiger ***@***.***> wrote:
@hp197 <https://github.com/hp197> Thanks for this PR, looks good to me
... could you also please add an entry in README.md?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#262 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKRKZGPMKMV452LI4XE2KLS5UJBFANCNFSM4XBLOTIQ>
.
|
|
squashed commit documentation into |
Signed-off-by: Henry Pauli <henry@mixict.nl>
|
Perfect, can we merge this? |
|
go go go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered issues where we have duplicate declaration in our environment.
This is mainly with modules who manage their own system user/group (for example a mysql/postgres user).
When both the other module and os-hardening define the user you get a duplicate declaration.
We do want to implement most parts of this module, but want to be able to exclude the managed (system) user account.