Install cp2k binaries #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-zero
reviewed
Jan 12, 2021
| @@ -1226,3 +1226,5 @@ target_link_libraries(dumpdcd PRIVATE cp2kobj) | |||
| add_executable(xyz2dcd motion/xyz2dcd.F) | |||
| set_target_properties(xyz2dcd PROPERTIES LINKER_LANGUAGE Fortran) | |||
| target_link_libraries(xyz2dcd PRIVATE cp2kobj) | |||
|
|
|||
| install(TARGETS cp2k cp2k-bin memory_utilities_unittest parallel_rng_types_unittest graph dumpdcd xyz2dcd) | |||
There was a problem hiding this comment.
the unittests are something I would not install, and if they are to be installed I'd put them into libexec/ since they might not be necessarily meant to be run directly by a user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.