Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Python 3 #3

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Compatibility with Python 3 #3

wants to merge 23 commits into from

Commits on Feb 4, 2020

  1. The following changes made: 

    1. Modify pulsar.py to add orbital degradation factor as an attribute to each pulsar object (orb_degfac).
2. Modify survey.py to record the snr for each pulsar object in its pulsar.snr attribute.
    @NihanPol
    NihanPol committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    6dd1f6a View commit details
    Browse the repository at this point in the history

  2. Add gitignore and fix typo

    @NihanPol
    NihanPol committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    18efd05 View commit details
    Browse the repository at this point in the history

  3. fix incompatibility in makefile

    @NihanPol
    NihanPol committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    b215675 View commit details
    Browse the repository at this point in the history

  4. ensure pickle import compatibility between py2 and py3

    @NihanPol
    NihanPol committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    a59b31a View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. add SNR of only detected pulsar to their instance

    @NihanPol
    NihanPol committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    477412c View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Fix print statements for Py3.xx

    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    b194af9 View commit details
    Browse the repository at this point in the history

  2. Fix function definition (line 66; def calc_true) in galacticops.py

    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    f776e63 View commit details
    Browse the repository at this point in the history

  3. Fix another function definition in galacticops.py (line 213)

    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    29526f6 View commit details
    Browse the repository at this point in the history

  4. fix print statement in orbitalparams.py

    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    cee53e3 View commit details
    Browse the repository at this point in the history

  5. fix print statement in dosurvey.py

    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    e49a007 View commit details
    Browse the repository at this point in the history

  6. fix compatibility issue with inspect.getargspec at line 156 in popula… 

    …te.py
    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    a481d00 View commit details
    Browse the repository at this point in the history

  7. make change to inspect.getargspec compatible with both py2.xx and py3.xx

    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    b389783 View commit details
    Browse the repository at this point in the history

  8. Fix instances where comparison with None fails in Py3.xx in populate.… 

    …py and pulsar.py
    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3aa8c36 View commit details
    Browse the repository at this point in the history

  9. Explicitly make all initial strings as byte strings since this is not… 

    … done implicitly in Py3.xx
    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    69b85c7 View commit details
    Browse the repository at this point in the history

  10. Fix another instance of explicitly setting strings to dtype=bytes sin… 

    …ce Py3.xx does not do this implicitly
    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    899119c View commit details
    Browse the repository at this point in the history

  11. Fix print statememts in evolve.py

    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    2b6f172 View commit details
    Browse the repository at this point in the history

  12. fix the unicode string --> byte string issue in a slightly different,… 

    … better way
    @NihanPol
    NihanPol committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    8982511 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. ensure log-space sampling for uniform sampling in distributions.py

    @NihanPol
    NihanPol committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    394537b View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Add orbital parameters to the Pulsar object. These include: 

    m1 -> mass of psr
m2 -> mass of companion
om -> angle of periastron passage (omper)
inc -> inclination of BNS system
ec -> eccentricity of BNS
pod -> orbital period of BNS
m -> harmonic at which power is computed

Consequently, added functionality for Population object to hold the ranges of the BNS orbital parameters.

populate.generate() now draws uniformly from the range of orbital parameters supplied by the user (as a dictionary).
    @nspol
    nspol committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    32567b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. fix gpsfrac == NoneType issue 

    cannot compare float to NoneType in Python3. changed gpsargs to [-1, -1] from [-1, None] so that condition evaluates to true for default case.
    @NihanPol
    NihanPol authored Jun 2, 2020
    Configuration menu
    Copy the full SHA
    609a3e2 View commit details
    Browse the repository at this point in the history

  2. change gpsfrac to -1 from None 

    cannot compare floats to NoneType in py3. change gpsfrac to -1 so that default behavior is satisfied.
    @NihanPol
    NihanPol authored Jun 2, 2020
    Configuration menu
    Copy the full SHA
    953e18d View commit details
    Browse the repository at this point in the history

  3. Fix gpsfrac issue due to definition in __main__

    @nspol
    nspol committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    f8a328c View commit details
    Browse the repository at this point in the history

  4. change doublespec from Nonetype to -1 to fix incompatibility in py3

    @nspol
    nspol committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    e414296 View commit details
    Browse the repository at this point in the history