Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to SQLite3 #28

Merged
merged 7 commits into from
Jun 4, 2022
Merged

Moving to SQLite3 #28

merged 7 commits into from
Jun 4, 2022

Conversation

devanshshukla99
Copy link
Owner

@devanshshukla99 devanshshukla99 commented Jun 4, 2022

Fixes #25

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2022

Codecov Report

Merging #28 (0845b55) into main (c724ec7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          14       14           
  Lines         214      215    +1     
=======================================
+ Hits          213      214    +1     
  Misses          1        1           
Impacted Files Coverage Δ
examples/response_decorator_urllib3.py 100.00% <ø> (ø)
tests/test_aiohttp.py 100.00% <ø> (ø)
tests/test_examples.py 100.00% <ø> (ø)
tests/test_requests.py 100.00% <ø> (ø)
tests/test_urllib.py 100.00% <ø> (ø)
tests/test_urllib3.py 100.00% <ø> (ø)
examples/insert_get_database.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c724ec7...0845b55. Read the comment docs.

@devanshshukla99 devanshshukla99 marked this pull request as ready for review June 4, 2022 13:40
Copy link
Owner Author

@devanshshukla99 devanshshukla99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@devanshshukla99 devanshshukla99 merged commit 4203185 into main Jun 4, 2022
@devanshshukla99 devanshshukla99 deleted the database_update branch June 4, 2022 14:56
@devanshshukla99 devanshshukla99 added the enhancement New feature or request label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix database
2 participants