Handled 404,500,422 Errors #58
Conversation
Pushed handling 404,500, etc right to development.rb
Pushed configuration for handling 404,500, etc right to development.rb
|
|
||
| def not_found | ||
| if env["REQUEST_PATH"] =~ /^\/api/ | ||
| render :json => {:error => "not-found"}.to_json, :status => 404 |
There was a problem hiding this comment.
You can use the new hash syntax here: json: {error: 'not-found'}.to_json, status: 404
There was a problem hiding this comment.
Lolll. @luizvarela right.
Pushed configuration for handling 404,500, etc right to development.rb
|
|
||
| def not_found | ||
| if env["REQUEST_PATH"] =~ /^\/api/ | ||
| render :json => {:error => "not-found"}.to_json, :status => 404 |
There was a problem hiding this comment.
I think a simple rescue_from will solve this problem to handle errors on the api side.
There was a problem hiding this comment.
@luizvarela But talk of rescue_from, hope this wont rescue something else. Often am advised not to use it. Can you refactor this and well secured enough and let's see whats up?
There was a problem hiding this comment.
I can send a pull request later using the rescue_from approach. For now, it looks good
There was a problem hiding this comment.
So you agree we Merge?
There was a problem hiding this comment.
Sure @AfolabiOlaoluwa, let's do this... 👍 🎉
There was a problem hiding this comment.
Okay. I refactored to new hash syntax
edited application_controller.rb to use new hash syntax
@luizvarela @SundayAdefila. Review this.
See graphical representation below: