[pull] master from FNA-XNA:master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Fixes parsing for big-endian SoundBanks.
Fixes parsing for big-endian SoundBanks.
Fixes parsing for big-endian SoundBanks
incorrect frequency and q variation calculations. Co-authored-by: Ethan Lee <flibitijibibo@gmail.com>
Even with the engine procedure callback, Wine has to swap it to another thread in order for the application-provided callbacks to be executed in the context of a Wine thread, and not the SDL audio created thread. This will also allow Wine get rid of the FAudio SDL2 dependency, which is desirable, considering we'll ultimately need FAudio built as PE.
We might overflow the read buffer otherwise.
Previously, FAudio with `PLATFORM_WIN32` would only list the default audio device. This reworks the FAudio `PLATFORM_WIN32` code to enable access to every audio device on the system. In order to preserve the existing behavior (and XAudio2 compabitility), the audio devices are re-ordered so the first device is always the default one. In addition: * Properly populates the `DisplayName` field in `FAudioDeviceDetails`. Previously, it was set to the device GUID. * [windows] Return error code for DefaultDeviceIndex * Rework `FAudio_DefaultDeviceIndex` to return the Windows API error code and take the `defaultDeviceIndex` as parameter. Test: Local build with visualboyadvance-m
fixed up some SDL 3 renamed symbols
Macro has been renamed in libsdl-org/SDL@32907a9
Export the FAudio::FAudio-shared target when building a shared library and the FAudio::FAudio-static target when building a static library to separate target files so that both can be installed at the same time. Alias FAudio::FAudio to the shared library if it is installed and the static library otherwise in the Config. Signed-off-by: Rafael Kitover <rkitover@gmail.com>
…ngth. This is important for songs that are _exactly_ X seconds, because the decode length will always be the buffer size, so it would never detect the end of the stream until it decoded exactly 0, which wouldn't trip a buffer submission and therefore FAUDIO_END_OF_STREAM would never get sent.
Let us never speak of the shortcut again.
Co-authored-by: Ethan Lee <flibitijibibo@gmail.com>
One notable change is SDL2 Linux now builds SDL3 in release, because the soname is different in debug mode for some reason???
The Wine build in particular needs some declarations that 8's headers don't have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )