Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company setup should have a logo field #73

Closed
silentworks opened this issue Feb 10, 2019 · 10 comments
Closed

Company setup should have a logo field #73

silentworks opened this issue Feb 10, 2019 · 10 comments

Comments

@silentworks
Copy link
Member

silentworks commented Feb 10, 2019

We should allow for a company to provide a logo when signing up.

@yawboakye
Copy link
Member

@silentworks @claudey Who to upload the images to?

@yawboakye
Copy link
Member

We can begin by asking for the URL to the logo. If they have a website they could have their logo on there and should be able to use the same link here. But that's not a good long term solution.

@bubunyo
Copy link

bubunyo commented Feb 26, 2019

We used to do this with AF Radio, these guys deleted the images and we were left with dead images. Just saying.

@seanmavley
Copy link
Contributor

as per the scenario @bubunyo mentioned, then I'm imagining if the image doesn't exist, a placeholder of sorts can be loaded instead

@bubunyo
Copy link

bubunyo commented Feb 26, 2019

I think cloudinary is a good option

@yawboakye
Copy link
Member

@bubunyo Sure, I was thinking of what would be the cheapest option in the interim. If we can go with them.

@bubunyo
Copy link

bubunyo commented Feb 27, 2019 via email

@claudey
Copy link
Member

claudey commented Feb 28, 2019

@bubunyo I'm guessing, per @seanmavley's suggestion, we can have an image like this to use, when they don't supply a logo url, an image like this loads from our images directory. That way we can delay cloudinary et al for some time.

screenshot 2019-02-28 at 4 38 35 pm

@yawboakye @silentworks thoughts?

@bubunyo
Copy link

bubunyo commented Mar 7, 2019

Makes sense to me.

@claudey
Copy link
Member

claudey commented Mar 22, 2019

Resolved in ebc4518

@claudey claudey closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants