Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localstack failing build Action #82

Closed
jcbhmr opened this issue Nov 25, 2022 · 2 comments · Fixed by #84
Closed

localstack failing build Action #82

jcbhmr opened this issue Nov 25, 2022 · 2 comments · Fixed by #84
Assignees

Comments

@jcbhmr
Copy link
Contributor

jcbhmr commented Nov 25, 2022

Right now the localstack feature is failing its tests (as of the latest commit at time of writing).

Image of the failed Action

image

image

The error message that kills the build process is:

AttributeError: module 'distutils.log' has no attribute 'warning'. Did you mean: 'warnings'?

Link to it in the Actions log

The most relevant result from Google seems to be: pypa/setuptools#3707. Here's the PR that supposedly fixes the issue: pypa/setuptools#3709. I don't know what the fix would be. Maybe this is just some issue upstream that will eventually go away?

@jcbhmr jcbhmr changed the title Fix failing tests for localstack Fix failing build Action for localstack Nov 25, 2022
@jcbhmr jcbhmr changed the title Fix failing build Action for localstack localstack failing build Action Nov 25, 2022
@danielbraun89 danielbraun89 self-assigned this Nov 26, 2022
@danielbraun89
Copy link
Member

Thanks for finding this

This seems to be solved in the very recent setuptools 65-6-3 (see changelog https://setuptools.pypa.io/en/latest/history.html#v65-6-3 )
So this might get solved in newly created pipx environment without any changes to the current scripts

However... currently scripts will rely on a preinstalled pipx (if exists ) - thus inheriting any old setuptools already in existence in the pipx shared bin folder
I believe the proper solution for this and many future errors that can occur, is to force latest version for setuptools (and also for pip and wheel for good measure) even when using a preexisting pipx
working on a PR

danielbraun89 added a commit that referenced this issue Nov 26, 2022
force updating setuptools even for pre-existing pipx environments

also forcing pip and wheel to eliminate future problems

Fixes #82
@jcbhmr
Copy link
Contributor Author

jcbhmr commented Nov 26, 2022

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants