-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Alpine to git
feature
#1008
Add support for Alpine to git
feature
#1008
Conversation
the alpine version of `grep` doesn't support PCRE
note: this won't install from source (due to build issues with musl) but will install using the `apk` package manager
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time in contributing the support for Alpine. Left some comments!
note: feature does not currently implement building from source on Alpine
still need to tweak the package dependencies and make config
no longer required with "NO_GETTEXT=YesPlease" make config
no longer required with "NO_GETTEXT=YesPlease" make config (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have failing tests and builds, can you help fix them? Thanks!
…talled); refactor test script names to remove major version suffix (since it isn't specified in the associated image tag)
using `jq` avoids the need for PCRE `grep` expression (not supported in Alpine)
…rom `install_git_from_src.sh` script
not present in local Git feature in `base-alpine` image `install.sh` script
…it feature in `base-alpine` image
…se-alpine` image no longer needed, based on initial testing
…al Git feature in `base-alpine` image `jq` package no longer needed
…e system package is not built with PCRE support)
apk
to Git featuregit
feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thank you so much 🎉
Looks like tests are failing for alpine |
This PR introduces support of Alpine Linux to the
git
dev container feature.