Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oryx - Clean up and shrink size #116

Merged
merged 8 commits into from
Aug 31, 2022
Merged

Conversation

samruddhikhandale
Copy link
Member

With this cleanup, the size of the docker layer for the oryx feature reduced from 2.6 GB to 205 MB

Before these changes

image

After

image

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner August 24, 2022 16:55
@samruddhikhandale samruddhikhandale changed the title Oryx - Clean up and shrunk size Oryx - Clean up and shrink size Aug 24, 2022
@joshspicer
Copy link
Member

Re: the oryx/jammy test missing libssl:

I spent (too much) time debugging this in the dotnet feature a month or so ago. I left some comments in the script that might be useful

https://github.com/devcontainers/features/blob/main/src/dotnet/install.sh#L328

@samruddhikhandale
Copy link
Member Author

samruddhikhandale commented Aug 24, 2022

Re: the oryx/jammy test missing libssl:

Even with installed libssl packages, the oryx build and oryx prep cmd fails. It looks like a upstream oryx issue. I have asked them about it in chat if they are aware, else I'll create issues on oryx and this repo for tracking.

We are realizing this 🐛 now because I added oryx prep in the test.sh in this PR.

image

@samruddhikhandale
Copy link
Member Author

It looks like a upstream oryx issue. I have asked them about it in chat if they are aware.

Spoke with the team, oryx is only currently supported ubuntu focal scm based build image

joshspicer
joshspicer previously approved these changes Aug 30, 2022
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline.

After adding a warning in the oryx/install.sh noting no support for jammy, this is good to override merge with the failing oryx jammy test.

We can leave it as another action item for devcontainers/cli#139 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants