Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-cli] - python3.12 - feature broken due to distutils module removed - code fix #909

Merged
merged 7 commits into from
Mar 27, 2024
Merged

[azure-cli] - python3.12 - feature broken due to distutils module removed - code fix #909

merged 7 commits into from
Mar 27, 2024

Conversation

gauravsaini04
Copy link
Contributor

Feature name:

  • Azure-cli

Description:

This PR fixes the following issue:

  • Azure-cli feature was broken due to distutils not provided as default in Python3.12 #899

Changelog:

  • Updated install.sh to add support for bookworm
  • Updated tests to validate that the issue was remediated

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 mentioned this pull request Mar 13, 2024
Closed
@gauravsaini04 gauravsaini04 marked this pull request as ready for review March 13, 2024 22:24
@gauravsaini04 gauravsaini04 requested a review from a team as a code owner March 13, 2024 22:24
samruddhikhandale
samruddhikhandale requested changes Mar 13, 2024
View reviewed changes
src/azure-cli/install.sh Outdated Show resolved Hide resolved
test/azure-cli/scenarios.json Outdated Show resolved Hide resolved
test/azure-cli/scenarios.json Outdated Show resolved Hide resolved
@samruddhikhandale samruddhikhandale linked an issue Mar 27, 2024 that may be closed by this pull request
Azure-cli feature is broken for Python 3.12 as the distutils module is removed #899
Closed
@samruddhikhandale samruddhikhandale merged commit 0a4fa18 into devcontainers:main Mar 27, 2024
11 checks passed
@gauravsaini04 gauravsaini04 deleted the az_python3_12_fix branch March 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhjmmmmmmmm hhjmmmmmmmm hhjmmmmmmmm approved these changes

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure-cli feature is broken for Python 3.12 as the distutils module is removed
3 participants
@gauravsaini04 @samruddhikhandale @hhjmmmmmmmm