Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerShell]- Fallback method with find_prev_vers_frm_git_tags() implemented #926

Conversation

gauravsaini04
Copy link
Contributor

Feature name:

  • Powershell

Description:

This PR adds the following functionality:

  • Added a second installation method using find_prev_version_from_git_tags() to install if rate limit for the user accessing GitHub api is reached and installation begins to fail using this fallback method as well..

Changelog:

  • Updated installation file install.sh
  • Updated corresponding tests

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner March 29, 2024 04:46
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment and we are all set ⚡

src/powershell/install.sh Show resolved Hide resolved
@samruddhikhandale samruddhikhandale merged commit 55dbe13 into devcontainers:main Apr 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants