Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop-lite]- libasound2 not installing in noble - issue #973

Merged
merged 5 commits into from
May 16, 2024
Merged

[Desktop-lite]- libasound2 not installing in noble - issue #973

merged 5 commits into from
May 16, 2024

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented May 15, 2024 •
edited
Loading

Feature name:

  • Desktop-lite

Description:

This PR introduces the following functionality :

  • As a resolution to Features issue #968
  • Upon introduction of Ubuntu-24.04 (noble numbat), build has been failing because of libasound2 not being currently available for Ubuntu-24.04, so as a result, switching to libasound2-dev as an alternative.

Changelog:

  • Updated install.sh
  • Updated tests to validate the above scenario

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner May 15, 2024 11:55
@gauravsaini04 gauravsaini04 mentioned this pull request May 15, 2024
Closed
samruddhikhandale
samruddhikhandale requested changes May 15, 2024
View reviewed changes
src/desktop-lite/devcontainer-feature.json Outdated Show resolved Hide resolved
src/desktop-lite/install.sh Outdated Show resolved Hide resolved
src/desktop-lite/install.sh Outdated Show resolved Hide resolved
test/desktop-lite/scenarios.json Outdated Show resolved Hide resolved
test/desktop-lite/desktop-lite_noble_numbat.sh Outdated Show resolved Hide resolved
@samruddhikhandale samruddhikhandale linked an issue May 16, 2024 that may be closed by this pull request
features/desktop-lite failed to install in ubuntu24.04 #968
Closed
samruddhikhandale
samruddhikhandale approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samruddhikhandale samruddhikhandale merged commit 4d2dabe into devcontainers:main May 16, 2024
12 checks passed
@gauravsaini04 gauravsaini04 deleted the desktop-lite_libasound2_ubuntu_noble_issue branch May 16, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

features/desktop-lite failed to install in ubuntu24.04
2 participants
@gauravsaini04 @samruddhikhandale