-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent trying to setState on unmounted VirtualList + checking for undefined state before comparison #66
prevent trying to setState on unmounted VirtualList + checking for undefined state before comparison #66
Conversation
7a0190d
to
670dbc4
Compare
670dbc4
to
ef74ca8
Compare
@developerdizzle sorry if this PR is a bit abrupt, I just wanted to fix some of the warnings/errors I ran into using this super rad component! |
@developerdizzle yoooo! you mind taking a look-see at this PR some time? |
@Ramshackle-Jamathon Can you add a patch version bump in package.json? |
Still not working, becouse you changed only file src/VirtualList.js, but in package.json is "main": "lib/VirtualList.js". |
@konradd93 my bad dude, I did check that my changes fixed the problem but I didn't include the build artifacts in my PR (the lib/ directory you're talking about). I should've ran the build when I pushed the version bump. @developerdizzle It should be resolved by running the build and releasing a patch |
"@developerdizzle It should be resolved by running the build and releasing a patch" @developerdizzle, can you do that? |
Any progress on this? Folks are noticing a version mismatch: #72 |
Version 2.2.4 has been published! My apologies for the delay. |
@developerdizzle You rock! |
fixes #59
fixes #65