Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent trying to setState on unmounted VirtualList + checking for undefined state before comparison #66

Merged
merged 4 commits into from
Dec 28, 2017

Conversation

Ramshackle-Jamathon
Copy link
Contributor

@Ramshackle-Jamathon Ramshackle-Jamathon commented Nov 29, 2017

fixes #59
fixes #65

@Ramshackle-Jamathon Ramshackle-Jamathon changed the title prevent trying to setState on unmounted VirtualList prevent trying to setState on unmounted VirtualList + checking for undefined state before comparison Nov 29, 2017
@Ramshackle-Jamathon
Copy link
Contributor Author

@developerdizzle sorry if this PR is a bit abrupt, I just wanted to fix some of the warnings/errors I ran into using this super rad component!

@Ramshackle-Jamathon
Copy link
Contributor Author

@developerdizzle yoooo! you mind taking a look-see at this PR some time?

@developerdizzle
Copy link
Owner

@Ramshackle-Jamathon Can you add a patch version bump in package.json?

@developerdizzle developerdizzle merged commit 42dbd7d into developerdizzle:master Dec 28, 2017
@konradd93
Copy link

konradd93 commented Jan 5, 2018

Still not working, becouse you changed only file src/VirtualList.js, but in package.json is "main": "lib/VirtualList.js".
Next time check your change really solve the problem before creating the pull request, please. ;)

@Ramshackle-Jamathon
Copy link
Contributor Author

@konradd93 my bad dude, I did check that my changes fixed the problem but I didn't include the build artifacts in my PR (the lib/ directory you're talking about). I should've ran the build when I pushed the version bump.

@developerdizzle It should be resolved by running the build and releasing a patch

@konradd93
Copy link

"@developerdizzle It should be resolved by running the build and releasing a patch"

@developerdizzle, can you do that?

@mikechabot
Copy link

Any progress on this? Folks are noticing a version mismatch: #72

@developerdizzle
Copy link
Owner

Version 2.2.4 has been published! My apologies for the delay.

@mikechabot
Copy link

@developerdizzle You rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check state throttleWithRAF causes setState warning
4 participants