Fix stale DOM caused by empty Fragments #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
force-pushed
the
fix_stale_fragment
branch
from
4687b95 to
f1fae8e
Compare
marvinhagemeister
force-pushed
the
fix_stale_fragment
branch
from
f1fae8e to
085399d
Compare
JoviDeCroock
approved these changes
Mar 31, 2019
|
This probably fixes: #1475? |
|
Only partially, in that issue there seem to be more problems causing havok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the DOM for
Fragmentswasn't cleared when they previously had children. This was most noticeable in thetododemo where the first added todo item could never be removed.Adds
+2 B🎉