-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalid path for export in package.json (v 5.0.0) #164
base: main
Are you sure you want to change the base?
Conversation
For those who use webpack and want a quick fix, while this isn't correctly addressed, you can create an alias and point to the correct file: In the webpack.config.js include: resolve: {
alias: {
'unfetch': path.resolve(__dirname, 'node_modules/unfetch/dist/unfetch.mjs'),
},
}, |
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Looks correct to me! |
@rschristian @developit pinging in case you have forgotten to approve |
Sorry, not a maintainer, my approval does nothing. Just a drive-by suggestion as I ran into this and was seeing if anyone had submitted a fix yet. |
Workes fine. Thanks |
This is pending a fix to a how unfetch 5 exports its files, e.g. developit/unfetch#164
This is pending a fix to a how unfetch 5 exports its files, e.g. developit/unfetch#164
Can this be merged? I really need this change since in cannot start storybook in my project, Thanks for fixing this! 🥳 |
@rschristian , Kindly approve & merge it |
|
But its showing that your review is pending.. ![]() |
Doesn't matter -- GitHub's UI is a bit weird there for sure, but the approval of non-maintainers does nothing. You'd see a "collaborator" badge (I think) next to my name if I was able to approve and merge. |
This would be really nice to have merged since it currently is unusable in For anyone else using
|
=> Failed to build the preview And if I'm importing
I'm still getting |
Without this patch people were experiencing problems when bundling the SDK. See issue ToucanProtocol#95 ToucanProtocol#95 The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch` 5.0.0 which currently has an issue with their module exports leading to an error when bundling the lib itself or any other lib that depends on `unfetch`. See this PR for more information: developit/unfetch#164 Once this PR is merged we can go back to the latest `isomorphic-unfetch` version.
Without this patch people were experiencing problems when bundling the SDK. See issue ToucanProtocol#95 ToucanProtocol#95 The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch` 5.0.0 which currently has an issue with their module exports leading to an error when bundling the lib itself or any other lib that depends on `unfetch`. See this PR for more information: developit/unfetch#164 Once the PR above is merged we can go back to the latest `isomorphic-unfetch` version.
Can someone merge this, please? |
An issue with `unfetch@5`, depended on by `isomorphic-unfetch@4.0.2`, breaks bundling with tools such as `esbuild` and `webpack`: developit/unfetch#164
Any chance this can get merged and published? Lots of bundler workarounds required right now 😅 |
First of all, thanks for this library! We have been using it for quite a long time, and it works like a charm.
Description
It seems that there are invalid values exported in the package.json https://github.com/developit/unfetch/blob/main/package.json#L18
It causes issue while using
unfetch
as a module, for instance, we use webpack and once upgraded to 5.0.0 it started to break the build with the given (not so clear, to say the least) error:Demo
Here you can see an example of this issue:
https://github.com/cristianoliveira/unfetch-issue-demo
Solution
After pointing to
src/index.mjs
it started to compile again and it is working as expected. 😄Let me know if this is the right solution.
Relates to
#163
#162