Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate MS and Bands Beyond Default RGB #178

Merged
merged 16 commits into from
Aug 19, 2020
Merged

Accommodate MS and Bands Beyond Default RGB #178

merged 16 commits into from
Aug 19, 2020

Conversation

martham93
Copy link
Contributor

allows users to optionally specify the number of bands and indices of bands to use when input image is a tif or vrt in a config file. The behavior will default to three band rgb if not specified. The .png tiles and image array in the data.npz will be written out in the same dtype as imagery in the tif is provided. This is useful for MS imagery.

Should the number of bands specified be removed as an optional input? and that number just derived from the lenght of the list of tile indices that's an optional input?
cc @drewbo

@martham93 martham93 added the enhancement New feature or request label Aug 18, 2020
@martham93 martham93 requested a review from drewbo August 18, 2020 01:30
Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool feature, main question about functionality is: how does this handle 5+ indices? There are some other changes and questions noted inline

@@ -72,3 +72,7 @@ Here is the full list of configuration parameters you can specify in a ``config.

**over_zoom**: int
An integer greater than 0. If set for XYZ tiles, it will fetch tiles from `zoom` + `over_zoom`, to create higher resolution tiles which fill out the bounds of the original zoom level.

**band_indicies**: list
A list of band incidies to pull from a tiff. Defaults to (1, 2, 3) if not specified. For using non-RGB tifs, ie MS tifs this should be over-written
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if this is specified for non-tifs? We should also define MS + spacenet

label_maker/images.py Outdated Show resolved Hide resolved
label_maker/package.py Outdated Show resolved Hide resolved
label_maker/package.py Outdated Show resolved Hide resolved
label_maker/utils.py Outdated Show resolved Hide resolved
label_maker/utils.py Outdated Show resolved Hide resolved
label_maker/utils.py Outdated Show resolved Hide resolved
@martham93 martham93 requested a review from drewbo August 18, 2020 20:27
label_maker/utils.py Outdated Show resolved Hide resolved
@martham93 martham93 requested a review from drewbo August 18, 2020 21:24
@drewbo drewbo merged commit c9a4ce2 into master Aug 19, 2020
@drewbo drewbo deleted the ms branch August 19, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants