DataFilterExtension bug - 'get_filter_value' trait of a ScatterplotLayer instance expected filter_size (3) to match 2nd dimension of numpy array

[jaanli]

Context

Need to make several dashboards that have filtering linked to a map (#353).

Issue

Cannot use DataFilter extension: getting this error -

TraitError: The 'get_filter_value' trait of a ScatterplotLayer instance expected filter_size (3) to match 2nd dimension of numpy array, not the ndarray array([[12500.],

To reproduce: https://github.com/jaanli/lonboard/blob/example-american-community-survey/examples/american-community-survey.ipynb

Acceptance-Criteria

Mapping various census variables and filtering using them for exploratory data analysis and understanding social value + capital deployment using our tax dollars.

[kylebarron]

You're passing

filter_extension = DataFilterExtension(filter_size=3)

If you're filtering on one column you need to remove that or set to 1 (the default)

Aside: We should probably create a bug-specific issue ticket format. cc @emmalu

[kylebarron]

Additionally you only need to create a multi-dimensional array when filter_size > 1, so you don't need the np.column_stack

[jaanli]

Awesome, figured it was something simple. Thank you Kyle!!

[jaanli]

Small note in case this is under active development: instead of filter_size, would a rename to num_filters be viable? Or setting this automatically based on filter values or range...

(Coming from machine learning, 'size' in variable names tend to be for other things.)

[jaanli]

Reopening this in case others run into this too:

After fixing the filter_size parameter, I am unable to see the output:

In VS Code (seems like a separate issue):

In Jupyter notebook on Chrome (started with jupyter notebook):

Any idea how to fix the display of the filters?

Getting closer! Super exciting :D

[jaanli]

Fixed! Had to:

• restart the Jupyter kernel to get it working in VS Code
• pass in a single slider instead of a MultiRangeSlider (was getting size mismatch errors otherwise that I couldn't figure out - could add different error messages when someone tries to pass a single slider to a MultiRangeSlider as a nice-to-have?)

Thank you!!

Super exciting!!

[emmalu]

Aside: We should probably create a bug-specific issue ticket format. cc @emmalu

💯 Will do!

[kylebarron]

Small note in case this is under active development: instead of filter_size, would a rename to num_filters be viable?

I agree that I don't love filter_size, but that's the term used by upstream deck.gl and I'm reluctant to remove this consistency. We try to document this in the API docs https://developmentseed.org/lonboard/latest/api/layer-extensions/data-filter-extension/#lonboard.layer_extension.DataFilterExtension.filter_size. (Thought it is a little unclear the distinction between constructor parameters and layer parameters in the docs)