Move selected_bounds from Layer to Map
#676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
changed the title
selected_bounds from Layer to Map
Merged
kylebarron
added a commit
that referenced
this pull request
Oct 7, 2024
### Change list - Updated changelog - Added `model.save_changes` that was left out from #676 - Minor other fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selected_boundsshould be a property of the Map. In the future, when we use deck.gl to perform picking, we'll haveselected_indicesas a property of each individual layer. This is necessary because the data is a property of each layer, whileOr alternatively if we perform data filtering on the Python side, then in the future we could also add
selected_boundsto each layer (though probably as a private attribute)