fix: improve link processing #95
Merged
+793
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transformation - Added `get_base_url` utility to reconstruct the client's base URL from forwarded headers. - Updated `ProcessLinksMiddleware` to utilize the new utility for transforming links in responses. - Improved link transformation logic to handle various scenarios, including different hostnames and ports. - Refactored tests for `ProcessLinksMiddleware` to cover new functionality and edge cases.
alukach
force-pushed
the
fix/improved-link-processing
branch
from
eadb37f to
8e0d07b
Compare
alukach
commented
Sep 8, 2025
alukach
pushed a commit
that referenced
this pull request
Sep 8, 2025
🤖 I have created a release *beep* *boop* --- ## [0.9.2](v0.9.1...v0.9.2) (2025-09-08) ### Bug Fixes * improve link processing ([#95](#95)) ([e52b5a9](e52b5a9)) * properly return error on invalid CQL2 filters ([5c5c856](5c5c856)) ### Documentation * enhance middleware stack documentation with detailed descriptions and execution order ([06b51cb](06b51cb)) * update filter class path syntax ([a7f5b1b](a7f5b1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: ds-release-bot[bot] <116609932+ds-release-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect that upstream STAC APIs will set the origin of URLs contained in the
hrefproperty of thelinksarray to be properly pointed to the STAC Auth Proxy URL based on theForwardedheader we provide. However, in certain configurations, upstream APIs don't perform this change (e.g. the proxy headers are not properly forwarded to the upstream STAC API via a reverse proxy). This PR updates how we rework links to ensure that links that have an origin and path matching the path of the upstream STAC API will be reworked to instead point to the origin and potential path of the STAC Auth Proxy.