Allow directory with template overrides #9
Conversation
| @@ -41,7 +41,7 @@ async def features( | |||
| limit: int = None, | |||
| offset: int = None, | |||
| **kwargs: Any, | |||
| ) -> Items: | |||
| ) -> FeatureCollection: | |||
There was a problem hiding this comment.
?
Items is a FeatureCollection based model
tifeatures/tifeatures/model.py
Lines 114 to 134 in 28afbd8
(Gives better documentation)
There was a problem hiding this comment.
Mypy was complaining, i was just trying to get the tests to pass (same with everything in that last commit).
|
|
||
| url = self.url_for(request, "items", collectionId=collection.id) | ||
| if query_params: | ||
| url += f"?{query_params}" | ||
| url += f"?{QueryParams(**query_params)}" |
There was a problem hiding this comment.
is this related to the PR topic?
I'm fine with the change, but I worry that I did use this kind of style at multiple places 🤷♂️
There was a problem hiding this comment.
Again, mypy didn't like that query_params was a dict in some places and QueryParama elsewhere
| def create_html_response( | ||
| request: Request, data: str, template_name: str | ||
| ) -> HTMLResponse: | ||
| ) -> _TemplateResponse: |
| settings = APISettings() | ||
|
|
||
|
|
||
| class SearchPathTemplates(Jinja2Templates): |
There was a problem hiding this comment.
what about something a bit simpler:
template_dir = str(pathlib.Path(__file__).parent.joinpath("templates"))
templates = Jinja2Templates(directory=template_dir)
def create_template_response(name: str, context: dict, **kwargs: Any):
if settings.template_directory:
custom_templates = Jinja2Templates(directory=settings.template_directory)
try:
return custom_templates.TemplateResponse(name, context, **kwargs)
except: # TODO Add more precise exception handling
pass
return templates.TemplateResponse(name, context, **kwargs)There was a problem hiding this comment.
The thing i like about extending SearchPathTemplates is that it allows us to use the native tooling in jinja and could handle several paths if anyone needed as well.
There was a problem hiding this comment.
👍 it seems you can do this without re-writing your own class encode/starlette#1214
|
Closing this PR out in favor of PR #11. |
Allow a directory with templates to override the default templates that are delivered with tifeatures.