Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STACK_ as prefix; wrong case in dir; NAME instead of PROJECT #211

Merged
merged 5 commits into from
Feb 4, 2021

Conversation

fredliporace
Copy link
Contributor

@fredliporace fredliporace commented Feb 3, 2021

👋

I personally prefer TITILER_ as prefix instead of STACK_, if you agree I can change the PR to use TITILER_. But as it is it makes things consistent with STACK_.

@vincentsarago
Copy link
Member

@fredliporace thanks for this PR.

I think it will be good to use TITILER_STACK instead of STACK or TITILER.

env_prefix = "STACK_"

we can also change the env of the API to TITILER_API (instead of API)

env_prefix = "API_"

@fredliporace
Copy link
Contributor Author

@vincentsarago I was working on a branch based on 0.1.0a14 and commiting simple documentation updates I flagged while updating my own deployment. Changing to TITILER_API seems to affect some testing and in my environment the testing fails for some reason I have to investigate... This last commit seems to be cover all the needed changes but right now I'm unable to run all tests locally as I would like.

@vincentsarago
Copy link
Member

@fredliporace the tests seems to work on CI 🤷

Maybe I'll wait for you to 👍 before merging.

CHANGES.md Outdated Show resolved Hide resolved
@fredliporace
Copy link
Contributor Author

@fredliporace the tests seems to work on CI

Maybe I'll wait for you to before merging.

I like to run the testing locally and on my repo CI before submitting the PR. Seems to be OK.

@vincentsarago
Copy link
Member

@fredliporace run the test on my computer and everything looks 👌. I'll merge this great PR 🙏

CHANGES.md Outdated Show resolved Hide resolved
@vincentsarago vincentsarago merged commit 7eb21e6 into developmentseed:master Feb 4, 2021
@fredliporace fredliporace deleted the 0.1.0a14update branch February 4, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants