-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STACK_ as prefix; wrong case in dir; NAME instead of PROJECT #211
STACK_ as prefix; wrong case in dir; NAME instead of PROJECT #211
Conversation
@fredliporace thanks for this PR. I think it will be good to use titiler/deployment/AWS/cdk/config.py Line 71 in c952bd4
we can also change the env of the API to TITILER_API (instead of API) Line 27 in c952bd4
|
@vincentsarago I was working on a branch based on 0.1.0a14 and commiting simple documentation updates I flagged while updating my own deployment. Changing to TITILER_API seems to affect some testing and in my environment the testing fails for some reason I have to investigate... This last commit seems to be cover all the needed changes but right now I'm unable to run all tests locally as I would like. |
@fredliporace the tests seems to work on CI 🤷 Maybe I'll wait for you to 👍 before merging. |
I like to run the testing locally and on my repo CI before submitting the PR. Seems to be OK. |
@fredliporace run the test on my computer and everything looks 👌. I'll merge this great PR 🙏 |
👋
I personally prefer TITILER_ as prefix instead of STACK_, if you agree I can change the PR to use TITILER_. But as it is it makes things consistent with STACK_.