-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Store Validation #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Iamdavidonuh
commented
Aug 14, 2024
•
edited
Loading
edited
- On creating a store, validate index and query models against supported models selected on AIProxy startup. We error if either the index or query models don't exist in the supported model's Vec.
- Added a new field max_token to specify the maximum token a model would accept
- Swap out AIModelManager Trait for a Model Enum of Image and Text variants, subsequent variants can be added when we support other models
- Added Subcommand to display supported models in verbose or limited mode
…et max_token_size for models
Iamdavidonuh
force-pushed
the
david/extend_aiquery
branch
from
August 14, 2024 22:59
2de8c13
to
21195c2
Compare
Test Results106 tests 106 ✅ 1m 16s ⏱️ Results for commit aab3fa4. ♻️ This comment has been updated with latest results. |
Benchmark Results
|
deven96
reviewed
Aug 16, 2024
deven96
reviewed
Aug 18, 2024
deven96
reviewed
Aug 18, 2024
deven96
reviewed
Aug 18, 2024
@deven96, Here's how the output looks like |
Awesome |
deven96
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.