Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Store Validation #80

Merged
merged 9 commits into from
Aug 18, 2024
Merged

Create Store Validation #80

merged 9 commits into from
Aug 18, 2024

Conversation

Iamdavidonuh
Copy link
Collaborator

@Iamdavidonuh Iamdavidonuh commented Aug 14, 2024

  • On creating a store, validate index and query models against supported models selected on AIProxy startup. We error if either the index or query models don't exist in the supported model's Vec.
  • Added a new field max_token to specify the maximum token a model would accept
  • Swap out AIModelManager Trait for a Model Enum of Image and Text variants, subsequent variants can be added when we support other models
  • Added Subcommand to display supported models in verbose or limited mode

Copy link

github-actions bot commented Aug 14, 2024

Test Results

106 tests   106 ✅  1m 16s ⏱️
  6 suites    0 💤
  2 files      0 ❌

Results for commit aab3fa4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 15, 2024

Benchmark Results

group                                                        main                                   pr
-----                                                        ----                                   --
store_batch_insertion_without_predicates/size_100            1.00  1705.7±24.60µs        ? ?/sec    1.01  1716.4±27.24µs        ? ?/sec
store_batch_insertion_without_predicates/size_1000           1.00     17.2±0.25ms        ? ?/sec    1.00     17.1±0.33ms        ? ?/sec
store_batch_insertion_without_predicates/size_10000          1.00    172.4±4.15ms        ? ?/sec    1.00    172.6±3.05ms        ? ?/sec
store_batch_insertion_without_predicates/size_100000         1.00  1729.8±21.58ms        ? ?/sec    1.01   1740.4±6.34ms        ? ?/sec
store_retrieval_no_condition/size_100                        1.00      2.7±0.03ms        ? ?/sec    1.00      2.7±0.04ms        ? ?/sec
store_retrieval_no_condition/size_1000                       1.02     19.4±0.32ms        ? ?/sec    1.00     19.0±0.23ms        ? ?/sec
store_retrieval_no_condition/size_10000                      1.00    187.2±1.15ms        ? ?/sec    1.00    187.0±2.48ms        ? ?/sec
store_retrieval_no_condition/size_100000                     1.01   1917.3±7.69ms        ? ?/sec    1.00   1895.8±9.59ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100                   1.00      2.8±0.02ms        ? ?/sec    1.00      2.8±0.02ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_1000                  1.00     20.2±0.11ms        ? ?/sec    1.00     20.3±0.28ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_10000                 1.01    204.5±1.12ms        ? ?/sec    1.00    202.6±1.25ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100000                1.02       2.1±0.01s        ? ?/sec    1.00       2.1±0.01s        ? ?/sec
store_sequential_insertion_without_predicates/size_100       1.00  1705.8±33.62µs        ? ?/sec    1.00  1709.3±33.99µs        ? ?/sec
store_sequential_insertion_without_predicates/size_1000      1.00     16.9±0.31ms        ? ?/sec    1.00     16.8±0.34ms        ? ?/sec
store_sequential_insertion_without_predicates/size_10000     1.01    169.3±3.44ms        ? ?/sec    1.00    167.3±6.08ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100000    1.00  1661.2±59.80ms        ? ?/sec    1.03  1715.1±27.72ms        ? ?/sec

@Iamdavidonuh
Copy link
Collaborator Author

@deven96, Here's how the output looks like

Screenshot 2024-08-18 at 9 57 36 PM
Screenshot 2024-08-18 at 9 58 01 PM

@deven96
Copy link
Owner

deven96 commented Aug 18, 2024

@deven96, Here's how the output looks like

Screenshot 2024-08-18 at 9 57 36 PM Screenshot 2024-08-18 at 9 58 01 PM

Awesome

@Iamdavidonuh Iamdavidonuh merged commit 71140ee into main Aug 18, 2024
4 of 5 checks passed
@Iamdavidonuh Iamdavidonuh deleted the david/extend_aiquery branch August 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants