Add golangci-lint linter to enforce that the io/ioutil
package is not used anymore
#34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes use of the
golangci-lint
[1] linters aggregator, configured with thedepguard
[2] linter to enforce that the deprecatedio/ioutil
[3] package is not used anymore in the code.NOTE: Ideally, we should use all linters enabled by default by
golangci-lint
. But doing so reports a lot of issues, not relevant to the issue here (which is to enforce that 'io/ioutil' is not used anymore).Enabling the default linters and fixing the issues reported can be done in a subsequent issue/PR.
[1] https://golangci-lint.run/
[2] https://golangci-lint.run/usage/linters/#depguard
[3] https://pkg.go.dev/io/ioutil#pkg-overview
Which issue(s) does this PR fix
Fixes devfile/api#1257
PR acceptance criteria
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
Below is an example of error reported should
io/ioutil
be used again: