Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stale Workflow #1566

Merged
merged 2 commits into from
May 27, 2024
Merged

Update Stale Workflow #1566

merged 2 commits into from
May 27, 2024

Conversation

Jdubrick
Copy link
Contributor

What does this PR do?

Updates stale workflow to address older issues not being properly marked as stale. In the workflow we had a start_date which by their docs means any PR or issue opened before that date is not going to be checked. Additionally, added ascending: true so that it will start from the lowest issue # item and work its way to the newer ones, ensuring that the oldest issues are checked first.

Which issue(s) does this PR fix

fixes #1529
fixes #1528

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer

@Jdubrick
Copy link
Contributor Author

Failing check unrelated to my changes, will rerun to see if it changes the outcome.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor Author

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

@thepetk
Copy link
Contributor

thepetk commented May 23, 2024

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

Ive noticed the same behaviour in other prs (similar error trace). Id suggest waiting a little bit before investigating as the PR is not so urgent and we can retest later. Wdyt?

@Jdubrick
Copy link
Contributor Author

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

Ive noticed the same behaviour in other prs (similar error trace). Id suggest waiting a little bit before investigating as the PR is not so urgent and we can retest later. Wdyt?

Sounds good to me. Can give it some time and revisit on Monday, if the checks are still failing we can bring it up in standup about pushing through anyway if unrelated

@thepetk
Copy link
Contributor

thepetk commented May 23, 2024

@thepetk workflow keeps failing but I highly doubt it is because of the changes in this PR. Wdyt is the course of action?

Ive noticed the same behaviour in other prs (similar error trace). Id suggest waiting a little bit before investigating as the PR is not so urgent and we can retest later. Wdyt?

Sounds good to me. Can give it some time and revisit on Monday, if the checks are still failing we can bring it up in standup about pushing through anyway if unrelated

Yeah I agree. Is very unlikely to be related with the PR :D

@thepetk
Copy link
Contributor

thepetk commented May 24, 2024

/retest

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Copy link

openshift-ci bot commented May 27, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label May 27, 2024
@Jdubrick
Copy link
Contributor Author

@thepetk rebase and fixing some whitespace seemed to fix the issue. Weird but it did the trick. Can you re-review please?

@thepetk
Copy link
Contributor

thepetk commented May 27, 2024

@thepetk rebase and fixing some whitespace seemed to fix the issue. Weird but it did the trick. Can you re-review please?

Very weird :D But yeah my review remains the same. Nice addition to the workflow!

@Jdubrick Jdubrick merged commit 8d82c21 into devfile:main May 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants