Dockerfile Outerloop Support #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maysunfaisal
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
sleshchenko
reviewed
Aug 10, 2021
amisevsk
reviewed
Aug 10, 2021
There was a problem hiding this comment.
As we briefly discussed, I think having all fields at the same level in the spec could cause confusion (with the main example being the gitLocation field at the level as id and uri. I've opened PR maysunfaisal#1 as an example of what it might look like to shuffle around fields for clarity.
kim-tsao
reviewed
Aug 10, 2021
maysunfaisal
added a commit
to maysunfaisal/api
that referenced
this pull request
Aug 11, 2021
Suggested update to PR devfile#580
maysunfaisal
changed the title
sleshchenko
reviewed
Sep 3, 2021
kadel
reviewed
Sep 3, 2021
amisevsk
approved these changes
Sep 8, 2021
sleshchenko
approved these changes
Sep 10, 2021
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Moves GitLocation in DockerfileImage Image component type under the Git struct to make clear that this field is intended only for use when specifying a git repo. (Files not regenerated for readability) Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
|
@sleshchenko could you pls re-review, I've updated the PR with your feedback |
amisevsk
approved these changes
Sep 16, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, maysunfaisal, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
This was referenced Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maysun J Faisal maysunaneek@gmail.com
What does this PR do?:
Which issue(s) this PR fixes:
Fixes #51
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer:
I've provided some devfile samples on how a devfile with outerloop build & deploy will look. There are also many snippets of the new component for tests that can be used as a guide or reference