-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dockerfile for parcel/watcher package fix #110
Conversation
@Jdubrick could you check if this workaround resolves the issue you are facing with apple silicon? |
I mentioned in the main issue for this that the changes weren't able to fully solve the issue and I was still receiving a 139 error code on the |
@Jdubrick yeah I agree. Might be not only one issue and I'm pretty sure we will find it again in the future. Although I'd suggest to merge a fix specifically for your case as atm we only know of this issue for the silicon case. |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
df93e11
to
b3fe21e
Compare
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do / why we need it
This PR tries to fix the issue with
@parcel/watcher
package and thenode-gyp
dependency. The issue comes from the2.0.4
of thewatcher
package. This is a known issue which has been fixed here nrwl/nx#19751. As a result in order to have a full fix of this issue we might need to update tonx 17.1.3
.As the update of
nx
dep might require a fair amount of changes to thepackage.json
of the project, as a temporary solution we can add overrides to thepackage.json
in order to use the version2.1.0
.Another required step is to install
gcc
,make
andpython3
deps.More info about the fixes can be found here: parcel-bundler/watcher#156 (comment) & here: nrwl/nx#19457
Other than that, the fix also introduces an ENV var in order to allow users to run the
build_viewer.sh
script with for specific architectures. This way people running on silicon can choose a different arch.Which issue(s) does this PR fix
Fixes devfile/api#1356
PR acceptance criteria
Update the sidebar if there is a new file added or an existing filename is changed
How to test changes / Special notes to the reviewer
In order to reproduce it to a non-silicon environment I've tried to run: