Skip to content

Commit

Permalink
Disable aliases for plugins and editors
Browse files Browse the repository at this point in the history
It's currently difficult to support aliases for chePlugin and cheEditor
components, since the component name no longer matches the container
that is created. This means that we cannot match endpoints to plugins
when they have an alias that is different from container name.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
  • Loading branch information
amisevsk committed Apr 3, 2020
1 parent cfc5a6c commit 93fdedb
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions pkg/adaptor/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func AdaptPluginComponents(workspaceId, namespace string, devfileComponents []v1

broker := metadataBroker.NewBroker(true)

metas, aliases, err := getMetasForComponents(devfileComponents)
metas, _, err := getMetasForComponents(devfileComponents)
if err != nil {
return nil, nil, err
}
Expand All @@ -44,9 +44,11 @@ func AdaptPluginComponents(workspaceId, namespace string, devfileComponents []v1
if err != nil {
return nil, nil, err
}
if aliases[plugin.ID] != "" {
component.Name = aliases[plugin.ID]
}
// TODO: Alias for plugins seems to be ignored in regular Che
// Setting component.Name = alias here breaks matching, as container names do not match alias
//if aliases[plugin.ID] != "" {
// component.Name = aliases[plugin.ID]
//}

components = append(components, component)
}
Expand Down

0 comments on commit 93fdedb

Please sign in to comment.