-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add GHA for PR previews through Surge #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HarshCasper, jc-berger The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I fear it does not work when the PR originates from a forked repository: it won't have access to the We had that issue in the che-docs repository, and we solved it as following:
|
I created a |
Consider adding the |
Failing check, probably because the fork doesn't have access to the |
Hi @themr0c I have added the Surge Token from my personal account on my fork. I will re-trigger the CI for it to run. |
8542e97
to
7535d4c
Compare
New changes are detected. LGTM label has been removed. |
The Surge deployed link is available here: devfile-docs-preview-pr-106.surge.sh The CI fails due to the resources not being available by integration (the GitHub token in my case). In my opinion, it is fit to be merged in the current state and we can check if the Surge deploys the next PR preview. |
Description
This PR adds a GHA Action to deploy preview PRs on Surge for easy reviews.
JIRA ID: https://issues.redhat.com/browse/RHDEVDOCS-3339