Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specified that devfiles are yaml files in the authoring stacks docs #116

Merged
merged 4 commits into from
Dec 22, 2021
Merged

specified that devfiles are yaml files in the authoring stacks docs #116

merged 4 commits into from
Dec 22, 2021

Conversation

jc-berger
Copy link
Contributor

@jc-berger jc-berger commented Dec 8, 2021

Fixes https://issues.redhat.com/browse/RHDEVDOCS-2459

Preview link: devfile-docs-preview-pr-116.surge.sh

As the Jira ticket asks for, this PR is to describe that devfiles are yaml files and to make this specification within the authoring stacks guides.

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Dec 8, 2021
@jc-berger jc-berger self-assigned this Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 13, 2021

Deploy PR Preview failed.

Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jc-berger, nitpick added.

@openshift-ci
Copy link

openshift-ci bot commented Dec 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, johnmcollier, maysunfaisal, rkratky

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Dec 22, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 22, 2021

New changes are detected. LGTM label has been removed.

@rkratky rkratky merged commit 67ae078 into devfile:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants