-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor preview #60
Merged
Merged
Refactor preview #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalmeida00
requested changes
Aug 11, 2023
hxsggsz
added a commit
that referenced
this pull request
Aug 11, 2023
hxsggsz
force-pushed
the
refactor-preview
branch
from
August 11, 2023 18:45
ba67406
to
39bbf32
Compare
aalmeida00
approved these changes
Aug 12, 2023
Alecell
suggested changes
Aug 13, 2023
aalmeida00
approved these changes
Aug 13, 2023
aalmeida00
requested changes
Aug 14, 2023
Alecell
suggested changes
Aug 15, 2023
hxsggsz
added a commit
that referenced
this pull request
Aug 15, 2023
hxsggsz
force-pushed
the
refactor-preview
branch
from
August 15, 2023 18:10
397ad51
to
b01b379
Compare
Alecell
approved these changes
Aug 16, 2023
Precisa resolver os comentários do @aalmeida00 e atualizar a branch! |
aalmeida00
approved these changes
Aug 16, 2023
Alecell
force-pushed
the
refactor-preview
branch
from
August 16, 2023 03:01
a11a29f
to
6db590f
Compare
Alecell
pushed a commit
that referenced
this pull request
Aug 16, 2023
Alecell
pushed a commit
that referenced
this pull request
Aug 23, 2023
Alecell
pushed a commit
that referenced
this pull request
Aug 23, 2023
aalmeida00
added a commit
that referenced
this pull request
Aug 24, 2023
* refactor: remove scope from commitizen * refactor: remove scope from commitMessage re #61 * feat: add landle and test button #63 (#65) * feat: add landle and button on testinho feat #63 * feat: add landle and button on testinho feat #63 * refactor: edited testinho.stories and ladle dependencie feat #63 * chore: move devDependencie misplaced as dependencie * refactor: edit component Testinho and remove useState --------- Co-authored-by: Andre Almeida <andre-silva78@hotmail.com> * feat: add stylelint on ci * fix: fix identation and error on ci file * fix: fix switch stylelint * fix: fix stylelint on textcopy * fix: fix stylelint on toggleSocialMedia * fix: fix stylelint on home * feat: create storie for switch component * refactor: add command to initialize ladle on package.json * fix: fix typo of switch css import * docs: add a new template for issues on github docs #82 * test: add unit tests for switch component test #67 * test: update checked on and off test description test #67 * test: make when click test async to pass on ci te #67 * style: update tests name style #67 * feat: Add zunstand package feat #30 * feat: add a example store feat #30 * feat: create use posts store initial and add tests feat #30 * refactor: export interface of posts store refactor #30 * refactor: usage of hook on testinho and update of tests refactor #30 * refactor: pull request suggestions * chore: update "scripts" position * ci: add playwright to github pipeline * chore: add playwright to the project That package came with a bunch of other files and configurations. We update the `.gitignore` to ignore on commit some of the local testing reports, added two more commands on `package.json`, create a jest config file *just* for playwright and I'm commiting out the examples folders, later we can probably remove them, but now lets that here for rerefence * chore: move jest from dependencies to devDependencies * refactor: make preview component to follow the styleguide re #59 * test: add tests for preview component test #59 * refactor: add space between the imports and the tests re #59 * refactor: update div to paragraph on preview re #60 * test: remove shoud prefix on test test #59 * refactor: update html from p to div re #59 * refactor: add children to component re #59 * style: update on test how to use the component style #59 * docs: Added badges and links to the readme (#83) * docs: Added badges and links to the readme * docs: changed readme links from develop to master --------- Co-authored-by: flavia <flaviafreirec@hotmail.com> Co-authored-by: Flávia Freire <54037222+flaviafreirec@users.noreply.github.com> Co-authored-by: hxsggsz <vt.hugo.2021@gmail.com> Co-authored-by: alecell <alecell.dev@gmail.com> Co-authored-by: Leandro Augusto <61525671+leandrokzu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #59
Refactor
refactor the preview component to follow the styleguide and add tests
Changelog
Checklist