Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 37 - Fazer Layer de repositório e package de email #146

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Issue 37 - Fazer Layer de repositório e package de email #146

merged 3 commits into from
Jul 23, 2024

Conversation

muritadb
Copy link
Contributor

@muritadb muritadb commented Jun 6, 2024

Closes #37

Feature

Criado interface para o envio e notificação de emails repositorios.

Checklist
  • Issue linked
  • Build working correctly
  • Tests created

zoldyzdk
zoldyzdk requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@zoldyzdk zoldyzdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Murita algo muito errado aconteceu ai, não tem como tu ter mexido em 86 arquivos kkkk

@zoldyzdk zoldyzdk linked an issue Jun 14, 2024 that may be closed by this pull request
Fazer Layer de repositório e package de email #37
Closed
@zoldyzdk zoldyzdk changed the base branch from issue-37 to main June 20, 2024 21:56
@muritadb
Copy link
Contributor Author

@Felipeness i need some review in my task, plis

GabrielTrindadeC
GabrielTrindadeC requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@GabrielTrindadeC GabrielTrindadeC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acredito que esta faltando algumas coisas, a task compreende a implementação do package, testes e use cases.

devlefel
devlefel requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@devlefel devlefel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muritadb aonde esta a implementacao dessa interface?

Precisamos dela nessa feature aqui

zoldyzdk
zoldyzdk requested changes Jul 16, 2024
View reviewed changes
infra/mail_repository.go Show resolved Hide resolved
@zoldyzdk zoldyzdk merged commit 63e713c into devhatt:main Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielTrindadeC GabrielTrindadeC GabrielTrindadeC requested changes

@devlefel devlefel devlefel requested changes

@zoldyzdk zoldyzdk zoldyzdk approved these changes

Assignees

@muritadb muritadb

Labels
None yet
Projects
PetDex backend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fazer Layer de repositório e package de email
4 participants
@muritadb @devlefel @GabrielTrindadeC @zoldyzdk