Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial project architecture #10

Merged
merged 7 commits into from
Dec 6, 2023
Merged

initial project architecture #10

merged 7 commits into from
Dec 6, 2023

Conversation

diogocaronte
Copy link
Contributor

No description provided.

aalmeida00
aalmeida00 requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@aalmeida00 aalmeida00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo PR, alguns pontinhos.

src/components/button/index.scss Outdated Show resolved Hide resolved
src/home/components/logged/index.scss Outdated Show resolved Hide resolved
src/home/index.scss Outdated Show resolved Hide resolved
src/utils/create-elements/index.spec.js Outdated Show resolved Hide resolved
src/utils/extract-elements/index.spec.js Outdated Show resolved Hide resolved
src/utils/id/index.spec.js Show resolved Hide resolved
src/utils/storage/index.spec.js Outdated Show resolved Hide resolved
diogocaronte
diogocaronte commented Dec 6, 2023
View reviewed changes
Copy link
Contributor Author

@diogocaronte diogocaronte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicionei os EOF rodando o prettier
Adicionei os testes requisitados

@aalmeida00 aalmeida00 merged commit 5c99667 into devhatt:main Dec 6, 2023
Alecell pushed a commit that referenced this pull request Dec 9, 2023
@diogocaronte @Alecell
initial project architecture (#10)
5210469 
* add initial architecture example

* fix node_modules in src

* new structure example

* refactor components

* refactor: remove unused dependency

* style: run prettier to fix EOF

* add more tests
geisabitt pushed a commit to geisabitt/pet-dex-frontend that referenced this pull request Jan 19, 2024
@diogocaronte @geisabitt
initial project architecture (devhatt#10)
75643ef 
* add initial architecture example

* fix node_modules in src

* new structure example

* refactor components

* refactor: remove unused dependency

* style: run prettier to fix EOF

* add more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalmeida00 aalmeida00 aalmeida00 approved these changes

@Alecell Alecell Alecell approved these changes

Assignees

@diogocaronte diogocaronte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diogocaronte @Alecell @aalmeida00