Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create the input text component #34

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

MateusHenriquegringo
Copy link
Contributor

@MateusHenriquegringo MateusHenriquegringo commented Dec 20, 2023

feat #21

  • Description
    create the input text component with support to standart and outlined designs
Visual evidences 🖼️

Screenshot from 2023-12-20 18-09-00

Screenshot from 2023-12-20 18-08-16
Screenshot from 2023-12-20 18-08-03

Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info N/A

src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
@Alecell
Copy link
Contributor

Alecell commented Dec 23, 2023

A versão contained me parece um pouco diferente da versão do layout, parece que o padding geral ta errado, precisa dar uma ajustada nisso.
image

Vi que vc adicionou o prefix icon que não tava nas specs! Bem observado, aproveitando precisamos que tenha um suffix icon tambem!
image

src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
@Alecell
Copy link
Contributor

Alecell commented Jan 8, 2024

BRABO

@Alecell Alecell merged commit 4def068 into devhatt:main Jan 8, 2024
geisabitt pushed a commit to geisabitt/pet-dex-frontend that referenced this pull request Jan 19, 2024
* feat: input text component

feat devhatt#21

* refactor: change px to rem in input text, edd the option to set de asset as prefix or suffix





fix devhatt#21

* style: changed px to rem in background-position, removed

fix devhatt#21

---------

Co-authored-by: Andre Almeida <andre-silva78@hotmail.com>
Co-authored-by: Alexandre Gomes <alecell.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants