This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Basic implementation of course view, fixes #270 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwgmeligmeyling
changed the title
LiamClark
approved these changes
Apr 9, 2017
| @@ -33,7 +35,10 @@ | |||
| public class CoursesBackend { | |||
|
|
|||
| @Inject | |||
| private CourseEditions courses; | |||
| private CourseEditions courseEditions; | |||
There was a problem hiding this comment.
Nit picky, but how do you feel about changing the field injection to constructor injection?
But if we want to remove that let's do so in a different pr.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #270